RE: [BLACKBOX] /NOSCROLL and Wine

From: null <">
Date: Tue, 12 May 2009 13:11:44 +0000

----boundary-LibPST-iamunique-98679563_-_-
Content-type: text/plain

Hi,

I glanced over the bug description you gave
http://bugs.winehq.org/show_bug.cgi?id=9453 but I have slight
problems to understand it.

Going into the source of BlackBox, I found in HostWindows:

IF noClientScroll THEN
        client := WinApi.CreateWindowExW({}, "MDICLIENT", NIL,
                                        {25, 30}, (* clipchildren, child *)
                                        0, 0, 0, 0,
                                        main, 32767, instance, SYSTEM.ADR(ccs))
  ELSE
        client := WinApi.CreateWindowExW({}, "MDICLIENT", NIL,
                                        {20, 21, 25, 30}, (* scroll, clipchildren, child *)
                                        0, 0, 0, 0,
                                        main, 32767, instance, SYSTEM.ADR(ccs))
END;

which implies to me that Wine does not handle the options correctly,
but with the patch it does. Shouldn't we reopen the Wine bug with
a better description of the problem?

regards

--
  Bernhard 
  e-mail: bernhard treutwein (at) verwaltung uni-muenchen de (work)
          bernhard (at) wildwein de (home)
 
> -----Original Message-----
> From: BlackBox [mailto:BLACKBOX{([at]})nowhere.xy> adimetrius{([at]})nowhere.xy> Sent: Tuesday, May 12, 2009 7:51 AM
> To: BLACKBOX{([at]})nowhere.xy> Subject: [BLACKBOX] /NOSCROLL and Wine
> 
> 
> Hi all,
> 
> i am using BB under wine, and the /NOSCROLL command line 
> option didn't work for me: i would always get scroll bars 
> when a window was moved beyond main client area. Under 
> Windows, this was not the case: the /NOSCROLL works just fine.
> 
> Recently i found a bug fix for Wine that solves the problem. 
> It's discussion can be found here:
> http://bugs.winehq.org/show_bug.cgi?id=9453
> 
> For convenience, i will post the patch itself at the end of 
> this email.
> 
> To apply it, you will need wine source code, of course, then 
> apply the patch file to mdi.c in the source tree (unless in 
> your version it is already included), then:
> IF you haven't built wine before THEN
>    build wine with "make && make install" or following 
> insructions in README
> ELSIF you have the file mdi.o (* from a previous build *) THEN
>    remove or rename mdi.o
>    from wine source root run "make". 
> 	(* this will make a new version of user32.dll.so in the 
> source tree *)
>    locate "user32.dll.so" in your local filesystem
>    replace the "user32.dll.so" in your local filesystem with 
> the newly make'd 
> user32.dll.so"
> END
> 
> Restart BB and enjoy!
> 
> Here is the patch:
> ----------------------------------------------------
> Index: mdi.c
> ===================================================================
> --- mdi.c	(revision 12767)
> +++ mdi.c	(arbetskopia)
> {([at]})nowhere.xy>      UINT      nTotalCreated;
>      UINT      mdiFlags;
>      UINT      sbRecalc;   /* SB_xxx flags for scrollbar fixup */
> +    DWORD     initialStyle; /* Style when window was created */
>  } MDICLIENTINFO;
>  
>  static HBITMAP hBmpClose   = 0;
> {([at]})nowhere.xy>  	ci->nTotalCreated	= 0;
>  	ci->frameTitle		= NULL;
>  	ci->mdiFlags		= 0;
> +	ci->initialStyle        = cs->style;
>          ci->hFrameMenu = GetMenu(cs->hwndParent);
>  
>  	if (!hBmpClose) hBmpClose = CreateMDIMenuBitmap();
> {([at]})nowhere.xy>      SCROLLINFO info;
>      RECT childRect, clientRect;
>      HWND *list;
> +    MDICLIENTINFO *ci;
>  
> +    ci = get_client_info(hwnd);
>      GetClientRect( hwnd, &clientRect );
>      SetRectEmpty( &childRect );
>  
> {([at]})nowhere.xy>  			info.nMin = childRect.left;
>  			info.nMax = childRect.right - clientRect.right;
>  			info.nPos = clientRect.left - childRect.left;
> -			SetScrollInfo(hwnd, SB_HORZ, &info, TRUE);
> +			if (ci->initialStyle & WS_HSCROLL)
> +			    SetScrollInfo(hwnd, SB_HORZ, &info, TRUE);
>  			if (scroll == SB_HORZ) break;
>  			/* fall through */
>  	case SB_VERT:
>  			info.nMin = childRect.top;
>  			info.nMax = childRect.bottom - 
> clientRect.bottom;
>  			info.nPos = clientRect.top - childRect.top;
> -			SetScrollInfo(hwnd, SB_VERT, &info, TRUE);
> +			if (ci->initialStyle & WS_VSCROLL)
> +			    SetScrollInfo(hwnd, SB_VERT, &info, TRUE);
>  			break;
>      }
>  }
> 
> 
> ----
> To unsubscribe, send a message with body "SIGNOFF BLACKBOX" 
> to LISTSERV{([at]})nowhere.xy> 
----boundary-LibPST-iamunique-98679563_-_-
Content-type: application/rtf
Content-transfer-encoding: base64
Content-Disposition: attachment; filename="rtf-body.rtf"
e1xydGYxXGFuc2lcYW5zaWNwZzEyNTJcZnJvbXRleHQgXGRlZmYwe1xmb250dGJsDQp7XGYwXGZz
d2lzcyBBcmlhbDt9DQp7XGYxXGZtb2Rlcm4gQ291cmllciBOZXc7fQ0Ke1xmMlxmbmlsXGZjaGFy
c2V0MiBTeW1ib2w7fQ0Ke1xmM1xmbW9kZXJuXGZjaGFyc2V0MCBDb3VyaWVyIE5ldzt9fQ0Ke1xj
b2xvcnRibFxyZWQwXGdyZWVuMFxibHVlMDtccmVkMFxncmVlbjBcYmx1ZTI1NTt9DQpcdWMxXHBh
cmRccGxhaW5cZGVmdGFiMzYwIFxmMFxmczIwIEhpLFxwYXINClxwYXINCkkgZ2xhbmNlZCBvdmVy
IHRoZSBidWcgZGVzY3JpcHRpb24geW91IGdhdmVccGFyDQpodHRwOi8vYnVncy53aW5laHEub3Jn
L3Nob3dfYnVnLmNnaT9pZD05NDUzIGJ1dCBJIGhhdmUgc2xpZ2h0XHBhcg0KcHJvYmxlbXMgdG8g
dW5kZXJzdGFuZCBpdC5ccGFyDQpccGFyDQpHb2luZyBpbnRvIHRoZSBzb3VyY2Ugb2YgQmxhY2tC
b3gsIEkgZm91bmQgaW4gSG9zdFdpbmRvd3M6XHBhcg0KXHBhcg0KSUYgbm9DbGllbnRTY3JvbGwg
VEhFTlxwYXINClx0YWIgY2xpZW50IDo9IFdpbkFwaS5DcmVhdGVXaW5kb3dFeFcoXHtcfSwgIk1E
SUNMSUVOVCIsIE5JTCxccGFyDQpcdGFiIFx0YWIgXHRhYiBcdGFiIFx0YWIgXHsyNSwgMzBcfSxc
dGFiICgqIGNsaXBjaGlsZHJlbiwgY2hpbGQgKilccGFyDQpcdGFiIFx0YWIgXHRhYiBcdGFiIFx0
YWIgMCwgMCwgMCwgMCxccGFyDQpcdGFiIFx0YWIgXHRhYiBcdGFiIFx0YWIgbWFpbiwgMzI3Njcs
IGluc3RhbmNlLCBTWVNURU0uQURSKGNjcykpXHBhcg0KICBFTFNFXHBhcg0KXHRhYiBjbGllbnQg
Oj0gV2luQXBpLkNyZWF0ZVdpbmRvd0V4Vyhce1x9LCAiTURJQ0xJRU5UIiwgTklMLFxwYXINClx0
YWIgXHRhYiBcdGFiIFx0YWIgXHRhYiBcezIwLCAyMSwgMjUsIDMwXH0sXHRhYiAoKiBzY3JvbGws
IGNsaXBjaGlsZHJlbiwgY2hpbGQgKilccGFyDQpcdGFiIFx0YWIgXHRhYiBcdGFiIFx0YWIgMCwg
MCwgMCwgMCxccGFyDQpcdGFiIFx0YWIgXHRhYiBcdGFiIFx0YWIgbWFpbiwgMzI3NjcsIGluc3Rh
bmNlLCBTWVNURU0uQURSKGNjcykpXHBhcg0KRU5EO1xwYXINClxwYXINCndoaWNoIGltcGxpZXMg
dG8gbWUgdGhhdCBXaW5lIGRvZXMgbm90IGhhbmRsZSB0aGUgb3B0aW9ucyBjb3JyZWN0bHksXHBh
cg0KYnV0IHdpdGggdGhlIHBhdGNoIGl0IGRvZXMuIFNob3VsZG4ndCB3ZSByZW9wZW4gdGhlIFdp
bmUgYnVnIHdpdGhccGFyDQphIGJldHRlciBkZXNjcmlwdGlvbiBvZiB0aGUgcHJvYmxlbT9ccGFy
DQpccGFyDQpyZWdhcmRzXHBhcg0KLS1ccGFyDQogIEJlcm5oYXJkIFxwYXINCiAgZS1tYWlsOiBi
ZXJuaGFyZCB0cmV1dHdlaW4gKGF0KSB2ZXJ3YWx0dW5nIHVuaS1tdWVuY2hlbiBkZSAod29yaylc
cGFyDQogICAgICAgICAgYmVybmhhcmQgKGF0KSB3aWxkd2VpbiBkZSAoaG9tZSlccGFyDQogXHBh
cg0KXHBhcg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLVxwYXINCj4gRnJvbTogQmxhY2tC
b3ggW21haWx0bzpCTEFDS0JPWEBMSVNUUy5PQkVST04uQ0hdIE9uIEJlaGFsZiBPZiBccGFyDQo+
IGFkaW1ldHJpdXNATUFJTC5SVVxwYXINCj4gU2VudDogVHVlc2RheSwgTWF5IDEyLCAyMDA5IDc6
NTEgQU1ccGFyDQo+IFRvOiBCTEFDS0JPWEBMSVNUUy5PQkVST04uQ0hccGFyDQo+IFN1YmplY3Q6
IFtCTEFDS0JPWF0gL05PU0NST0xMIGFuZCBXaW5lXHBhcg0KPiBccGFyDQo+IFxwYXINCj4gSGkg
YWxsLFxwYXINCj4gXHBhcg0KPiBpIGFtIHVzaW5nIEJCIHVuZGVyIHdpbmUsIGFuZCB0aGUgL05P
U0NST0xMIGNvbW1hbmQgbGluZSBccGFyDQo+IG9wdGlvbiBkaWRuJ3Qgd29yayBmb3IgbWU6IGkg
d291bGQgYWx3YXlzIGdldCBzY3JvbGwgYmFycyBccGFyDQo+IHdoZW4gYSB3aW5kb3cgd2FzIG1v
dmVkIGJleW9uZCBtYWluIGNsaWVudCBhcmVhLiBVbmRlciBccGFyDQo+IFdpbmRvd3MsIHRoaXMg
d2FzIG5vdCB0aGUgY2FzZTogdGhlIC9OT1NDUk9MTCB3b3JrcyBqdXN0IGZpbmUuXHBhcg0KPiBc
cGFyDQo+IFJlY2VudGx5IGkgZm91bmQgYSBidWcgZml4IGZvciBXaW5lIHRoYXQgc29sdmVzIHRo
ZSBwcm9ibGVtLiBccGFyDQo+IEl0J3MgZGlzY3Vzc2lvbiBjYW4gYmUgZm91bmQgaGVyZTpccGFy
DQo+IGh0dHA6Ly9idWdzLndpbmVocS5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTNccGFyDQo+IFxw
YXINCj4gRm9yIGNvbnZlbmllbmNlLCBpIHdpbGwgcG9zdCB0aGUgcGF0Y2ggaXRzZWxmIGF0IHRo
ZSBlbmQgb2YgXHBhcg0KPiB0aGlzIGVtYWlsLlxwYXINCj4gXHBhcg0KPiBUbyBhcHBseSBpdCwg
eW91IHdpbGwgbmVlZCB3aW5lIHNvdXJjZSBjb2RlLCBvZiBjb3Vyc2UsIHRoZW4gXHBhcg0KPiBh
cHBseSB0aGUgcGF0Y2ggZmlsZSB0byBtZGkuYyBpbiB0aGUgc291cmNlIHRyZWUgKHVubGVzcyBp
biBccGFyDQo+IHlvdXIgdmVyc2lvbiBpdCBpcyBhbHJlYWR5IGluY2x1ZGVkKSwgdGhlbjpccGFy
DQo+IElGIHlvdSBoYXZlbid0IGJ1aWx0IHdpbmUgYmVmb3JlIFRIRU5ccGFyDQo+ICAgIGJ1aWxk
IHdpbmUgd2l0aCAibWFrZSAmJiBtYWtlIGluc3RhbGwiIG9yIGZvbGxvd2luZyBccGFyDQo+IGlu
c3J1Y3Rpb25zIGluIFJFQURNRVxwYXINCj4gRUxTSUYgeW91IGhhdmUgdGhlIGZpbGUgbWRpLm8g
KCogZnJvbSBhIHByZXZpb3VzIGJ1aWxkICopIFRIRU5ccGFyDQo+ICAgIHJlbW92ZSBvciByZW5h
bWUgbWRpLm9ccGFyDQo+ICAgIGZyb20gd2luZSBzb3VyY2Ugcm9vdCBydW4gIm1ha2UiLiBccGFy
DQo+IFx0YWIgKCogdGhpcyB3aWxsIG1ha2UgYSBuZXcgdmVyc2lvbiBvZiB1c2VyMzIuZGxsLnNv
IGluIHRoZSBccGFyDQo+IHNvdXJjZSB0cmVlICopXHBhcg0KPiAgICBsb2NhdGUgInVzZXIzMi5k
bGwuc28iIGluIHlvdXIgbG9jYWwgZmlsZXN5c3RlbVxwYXINCj4gICAgcmVwbGFjZSB0aGUgInVz
ZXIzMi5kbGwuc28iIGluIHlvdXIgbG9jYWwgZmlsZXN5c3RlbSB3aXRoIFxwYXINCj4gdGhlIG5l
d2x5IG1ha2UnZCBccGFyDQo+IHVzZXIzMi5kbGwuc28iXHBhcg0KPiBFTkRccGFyDQo+IFxwYXIN
Cj4gUmVzdGFydCBCQiBhbmQgZW5qb3khXHBhcg0KPiBccGFyDQo+IEhlcmUgaXMgdGhlIHBhdGNo
OlxwYXINCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLVxwYXINCj4gSW5kZXg6IG1kaS5jXHBhcg0KPiA9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XHBhcg0KPiAtLS0gbWRp
LmNcdGFiIChyZXZpc2lvbiAxMjc2NylccGFyDQo+ICsrKyBtZGkuY1x0YWIgKGFyYmV0c2tvcGlh
KVxwYXINCj4gQEAgLTE0MCw2ICsxNDAsNyBAQFxwYXINCj4gICAgICBVSU5UICAgICAgblRvdGFs
Q3JlYXRlZDtccGFyDQo+ICAgICAgVUlOVCAgICAgIG1kaUZsYWdzO1xwYXINCj4gICAgICBVSU5U
ICAgICAgc2JSZWNhbGM7ICAgLyogU0JfeHh4IGZsYWdzIGZvciBzY3JvbGxiYXIgZml4dXAgKi9c
cGFyDQo+ICsgICAgRFdPUkQgICAgIGluaXRpYWxTdHlsZTsgLyogU3R5bGUgd2hlbiB3aW5kb3cg
d2FzIGNyZWF0ZWQgKi9ccGFyDQo+ICBcfSBNRElDTElFTlRJTkZPO1xwYXINCj4gIFxwYXINCj4g
IHN0YXRpYyBIQklUTUFQIGhCbXBDbG9zZSAgID0gMDtccGFyDQo+IEBAIC0xMDc1LDYgKzEwNzYs
NyBAQFxwYXINCj4gIFx0YWIgY2ktPm5Ub3RhbENyZWF0ZWRcdGFiID0gMDtccGFyDQo+ICBcdGFi
IGNpLT5mcmFtZVRpdGxlXHRhYiBcdGFiID0gTlVMTDtccGFyDQo+ICBcdGFiIGNpLT5tZGlGbGFn
c1x0YWIgXHRhYiA9IDA7XHBhcg0KPiArXHRhYiBjaS0+aW5pdGlhbFN0eWxlICAgICAgICA9IGNz
LT5zdHlsZTtccGFyDQo+ICAgICAgICAgIGNpLT5oRnJhbWVNZW51ID0gR2V0TWVudShjcy0+aHdu
ZFBhcmVudCk7XHBhcg0KPiAgXHBhcg0KPiAgXHRhYiBpZiAoIWhCbXBDbG9zZSkgaEJtcENsb3Nl
ID0gQ3JlYXRlTURJTWVudUJpdG1hcCgpO1xwYXINCj4gQEAgLTE3MTksNyArMTcyMSw5IEBAXHBh
cg0KPiAgICAgIFNDUk9MTElORk8gaW5mbztccGFyDQo+ICAgICAgUkVDVCBjaGlsZFJlY3QsIGNs
aWVudFJlY3Q7XHBhcg0KPiAgICAgIEhXTkQgKmxpc3Q7XHBhcg0KPiArICAgIE1ESUNMSUVOVElO
Rk8gKmNpO1xwYXINCj4gIFxwYXINCj4gKyAgICBjaSA9IGdldF9jbGllbnRfaW5mbyhod25kKTtc
cGFyDQo+ICAgICAgR2V0Q2xpZW50UmVjdCggaHduZCwgJmNsaWVudFJlY3QgKTtccGFyDQo+ICAg
ICAgU2V0UmVjdEVtcHR5KCAmY2hpbGRSZWN0ICk7XHBhcg0KPiAgXHBhcg0KPiBAQCAtMTc1OSwx
NCArMTc2MywxNiBAQFxwYXINCj4gIFx0YWIgXHRhYiBcdGFiIGluZm8ubk1pbiA9IGNoaWxkUmVj
dC5sZWZ0O1xwYXINCj4gIFx0YWIgXHRhYiBcdGFiIGluZm8ubk1heCA9IGNoaWxkUmVjdC5yaWdo
dCAtIGNsaWVudFJlY3QucmlnaHQ7XHBhcg0KPiAgXHRhYiBcdGFiIFx0YWIgaW5mby5uUG9zID0g
Y2xpZW50UmVjdC5sZWZ0IC0gY2hpbGRSZWN0LmxlZnQ7XHBhcg0KPiAtXHRhYiBcdGFiIFx0YWIg
U2V0U2Nyb2xsSW5mbyhod25kLCBTQl9IT1JaLCAmaW5mbywgVFJVRSk7XHBhcg0KPiArXHRhYiBc
dGFiIFx0YWIgaWYgKGNpLT5pbml0aWFsU3R5bGUgJiBXU19IU0NST0xMKVxwYXINCj4gK1x0YWIg
XHRhYiBcdGFiICAgICBTZXRTY3JvbGxJbmZvKGh3bmQsIFNCX0hPUlosICZpbmZvLCBUUlVFKTtc
cGFyDQo+ICBcdGFiIFx0YWIgXHRhYiBpZiAoc2Nyb2xsID09IFNCX0hPUlopIGJyZWFrO1xwYXIN
Cj4gIFx0YWIgXHRhYiBcdGFiIC8qIGZhbGwgdGhyb3VnaCAqL1xwYXINCj4gIFx0YWIgY2FzZSBT
Ql9WRVJUOlxwYXINCj4gIFx0YWIgXHRhYiBcdGFiIGluZm8ubk1pbiA9IGNoaWxkUmVjdC50b3A7
XHBhcg0KPiAgXHRhYiBcdGFiIFx0YWIgaW5mby5uTWF4ID0gY2hpbGRSZWN0LmJvdHRvbSAtIFxw
YXINCj4gY2xpZW50UmVjdC5ib3R0b207XHBhcg0KPiAgXHRhYiBcdGFiIFx0YWIgaW5mby5uUG9z
ID0gY2xpZW50UmVjdC50b3AgLSBjaGlsZFJlY3QudG9wO1xwYXINCj4gLVx0YWIgXHRhYiBcdGFi
IFNldFNjcm9sbEluZm8oaHduZCwgU0JfVkVSVCwgJmluZm8sIFRSVUUpO1xwYXINCj4gK1x0YWIg
XHRhYiBcdGFiIGlmIChjaS0+aW5pdGlhbFN0eWxlICYgV1NfVlNDUk9MTClccGFyDQo+ICtcdGFi
IFx0YWIgXHRhYiAgICAgU2V0U2Nyb2xsSW5mbyhod25kLCBTQl9WRVJULCAmaW5mbywgVFJVRSk7
XHBhcg0KPiAgXHRhYiBcdGFiIFx0YWIgYnJlYWs7XHBhcg0KPiAgICAgIFx9XHBhcg0KPiAgXH1c
cGFyDQo+IFxwYXINCj4gXHBhcg0KPiAtLS0tXHBhcg0KPiBUbyB1bnN1YnNjcmliZSwgc2VuZCBh
IG1lc3NhZ2Ugd2l0aCBib2R5ICJTSUdOT0ZGIEJMQUNLQk9YIiBccGFyDQo+IHRvIExJU1RTRVJW
QExJU1RTLk9CRVJPTi5DSFx9fQA3IPBTmbBU0Avg6w==
----boundary-LibPST-iamunique-98679563_-_---

Received on Tue May 12 2009 - 15:11:44 UTC